Skip to content

Commit

Permalink
fix(format-number): no decimals when no suffix is used (#43)
Browse files Browse the repository at this point in the history
  • Loading branch information
ReenigneArcher authored Sep 21, 2024
1 parent 4c2de07 commit d87beb8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/js/format-number.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function formatNumber(num, decimalPlaces = 1) {
} else if (num >= 1000) {
return (num / 1000).toFixed(decimalPlaces) + 'k';
} else {
return num.toFixed(decimalPlaces);
return num.toString()
}
}

Expand Down
6 changes: 3 additions & 3 deletions tests/format-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ describe('formatNumber function', () => {
[1234567, 2, '1.23M'], // 1.23 million
[1234, 1, '1.2k'], // 1.2 thousand
[1234, 2, '1.23k'], // 1.23 thousand
[123, 1, '123.0'], // 123 with 1 decimal place
[123, 2, '123.00'], // 123 with 2 decimal places
[123, 1, '123'], // 123 with 1 decimal place
[123, 2, '123'], // 123 with 2 decimal places
])('formats %i with %i decimal places as %s', (num, decimalPlaces, expected) => {
expect(formatNumber(num, decimalPlaces)).toBe(expected);
});

test('defaults to 1 decimal place if not provided', () => {
expect(formatNumber(1234567)).toBe('1.2M');
expect(formatNumber(1234)).toBe('1.2k');
expect(formatNumber(123)).toBe('123.0');
expect(formatNumber(123)).toBe('123');
});
});

0 comments on commit d87beb8

Please sign in to comment.