Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(legacy agents): do not upload themes unless Themerr is enabled #342

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 28, 2024

Description

Plex runs the Themerr agent even if it is disabled in the agent menu. Due to how we add theme songs using the API (instead of the plugin framework), we need to perform a check to see if we should add the theme or not.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (94e5193) 69.84% compared to head (be3ac3c) 70.06%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   69.84%   70.06%   +0.21%     
==========================================
  Files          12       12              
  Lines         985      992       +7     
==========================================
+ Hits          688      695       +7     
  Misses        297      297              
Flag Coverage Δ
Linux 70.06% <81.48%> (+0.21%) ⬆️
Windows 70.06% <81.48%> (+0.41%) ⬆️
macOS 69.85% <81.48%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/__init__.py 74.19% <ø> (ø)
Contents/Code/constants.py 86.84% <100.00%> (+1.12%) ⬆️
Contents/Code/migration_helper.py 85.36% <ø> (ø)
Contents/Code/scheduled_tasks.py 94.44% <ø> (ø)
Contents/Code/themerr_db_helper.py 88.09% <ø> (ø)
Contents/Code/webapp.py 66.46% <ø> (ø)
Contents/Code/youtube_dl_helper.py 74.32% <ø> (ø)
Contents/Code/general_helper.py 92.53% <93.75%> (+0.22%) ⬆️
Contents/Code/plex_api_helper.py 49.49% <50.00%> (-1.49%) ⬇️

@ReenigneArcher ReenigneArcher force-pushed the fix(legacy-agents)-do-not-upload-themes-unless-Themerr-is-enabled branch 4 times, most recently from df727a6 to 6af13d6 Compare January 28, 2024 16:14
@ReenigneArcher ReenigneArcher force-pushed the fix(legacy-agents)-do-not-upload-themes-unless-Themerr-is-enabled branch from 6af13d6 to be3ac3c Compare January 28, 2024 16:44
@ReenigneArcher ReenigneArcher marked this pull request as ready for review January 28, 2024 17:18
@ReenigneArcher ReenigneArcher merged commit 65d6a60 into master Jan 28, 2024
21 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(legacy-agents)-do-not-upload-themes-unless-Themerr-is-enabled branch January 28, 2024 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant