Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(dashboard): fix issue where local items could prevent ui cache from completing #341

Conversation

ReenigneArcher
Copy link
Member

Description

The dashboard could fail to cache if a local item with no database id was present in any section.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (65d6a60) 70.06% compared to head (89cb29c) 70.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   70.06%   70.14%   +0.08%     
==========================================
  Files          12       12              
  Lines         992      988       -4     
==========================================
- Hits          695      693       -2     
+ Misses        297      295       -2     
Flag Coverage Δ
Linux 70.14% <19.04%> (+31.63%) ⬆️
Windows 70.14% <19.04%> (+0.28%) ⬆️
macOS 69.93% <19.04%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/webapp.py 66.87% <19.04%> (+0.40%) ⬆️

@ReenigneArcher ReenigneArcher force-pushed the fix(dashboard)-fix-issue-where-local-items-could-prevent-ui-cache-from-completing branch from fa50517 to 89cb29c Compare January 28, 2024 17:27
@ReenigneArcher ReenigneArcher merged commit b0d8452 into master Jan 28, 2024
20 of 21 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(dashboard)-fix-issue-where-local-items-could-prevent-ui-cache-from-completing branch January 28, 2024 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant