Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

feat(shows): add support for tv shows #337

Merged
merged 25 commits into from
Mar 10, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 22, 2024

Description

This PR adds support for TV themes. The user must enable Themerr in the agent priority list for themes to be provided. Themerr should skip items that have a theme provided by Plex, by default.

Other notable changes in this PR

  • Improved theme provider detection
  • Plexhints updated with support for tv libraries, and support for different types of query requests during Plex bootstrapping step
  • PlexPartialObject used as typehint in more places
  • get_tmdb_id_from_imdb_id changed to get_tmdb_id_from_external_id in order to support imdb and tvdb
  • user_provided and themerr_provided properties in the web ui are replaced with theme_provider

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: Patch coverage is 83.67347% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 71.50%. Comparing base (67a47bd) to head (3ce3b2d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   70.10%   71.50%   +1.39%     
==========================================
  Files          12       12              
  Lines        1007     1074      +67     
==========================================
+ Hits          706      768      +62     
- Misses        301      306       +5     
Flag Coverage Δ
Linux 71.50% <83.67%> (+1.39%) ⬆️
Windows 71.50% <83.67%> (+1.39%) ⬆️
macOS 71.50% <83.67%> (+1.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/constants.py 86.84% <ø> (ø)
Contents/Code/default_prefs.py 100.00% <ø> (ø)
Contents/Code/themerr_db_helper.py 88.09% <ø> (ø)
Contents/Code/webapp.py 67.51% <100.00%> (+0.64%) ⬆️
Contents/Code/tmdb_helper.py 82.60% <92.30%> (+2.60%) ⬆️
Contents/Code/__init__.py 75.57% <85.71%> (+1.37%) ⬆️
Contents/Code/general_helper.py 88.17% <79.31%> (-4.37%) ⬇️
Contents/Code/plex_api_helper.py 53.49% <82.05%> (+4.00%) ⬆️

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the feat(shows)-add-support-for-tv-shows branch from 78549e6 to 9520d2c Compare January 22, 2024 15:31
@ReenigneArcher ReenigneArcher force-pushed the feat(shows)-add-support-for-tv-shows branch 10 times, most recently from 2ab942e to d48f4f4 Compare January 23, 2024 04:46
@ReenigneArcher ReenigneArcher force-pushed the feat(shows)-add-support-for-tv-shows branch from d48f4f4 to 3a11ae1 Compare January 23, 2024 04:50
tests/unit/test_general_helper.py Outdated Show resolved Hide resolved
tests/unit/test_general_helper.py Outdated Show resolved Hide resolved
tests/unit/test_general_helper.py Show resolved Hide resolved
tests/unit/test_general_helper.py Show resolved Hide resolved
tests/unit/test_themerr_db_helper.py Show resolved Hide resolved
Contents/Code/plex_api_helper.py Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
Contents/Code/plex_api_helper.py Outdated Show resolved Hide resolved
Contents/Code/webapp.py Outdated Show resolved Hide resolved
Contents/DefaultPrefs.json Outdated Show resolved Hide resolved
Contents/Code/general_helper.py Outdated Show resolved Hide resolved
Contents/Code/plex_api_helper.py Show resolved Hide resolved
# Conflicts:
#	Contents/Code/general_helper.py
#	Contents/Code/plex_api_helper.py
#	tests/unit/test_general_helper.py
# Conflicts:
#	tests/unit/test_migration_helper.py
@ReenigneArcher ReenigneArcher force-pushed the feat(shows)-add-support-for-tv-shows branch 4 times, most recently from 1c0ea5d to 2714dc2 Compare January 29, 2024 00:26
@ReenigneArcher ReenigneArcher force-pushed the feat(shows)-add-support-for-tv-shows branch from 2714dc2 to d31f208 Compare January 29, 2024 03:32
@ReenigneArcher ReenigneArcher marked this pull request as ready for review January 30, 2024 02:56
@ReenigneArcher ReenigneArcher merged commit f1da472 into master Mar 10, 2024
21 checks passed
@ReenigneArcher ReenigneArcher deleted the feat(shows)-add-support-for-tv-shows branch March 10, 2024 03:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant