Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(ui): url encode item titles in issue url #330

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 16, 2024

Description

Some item titles may not be properly quoted in the issue URL. This PR implements url quoting around the item title. I opted to use quote_plus from six to make it more similar to Python 3, which most developers are more familiar with at this point in time.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae60989) 69.78% compared to head (955ea98) 69.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   69.78%   69.87%   +0.09%     
==========================================
  Files          12       12              
  Lines         983      986       +3     
==========================================
+ Hits          686      689       +3     
  Misses        297      297              
Flag Coverage Δ
Linux 69.87% <100.00%> (+2.63%) ⬆️
Windows 69.87% <100.00%> (+0.29%) ⬆️
macOS 69.87% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/webapp.py 66.66% <100.00%> (+0.60%) ⬆️

Copy link
Collaborator

@zdimension zdimension left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ReenigneArcher ReenigneArcher merged commit 0a22784 into master Jan 17, 2024
21 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(ui)-url-encode-item-titles-in-issue-url branch January 17, 2024 00:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue with ThemerrDB issue urls
2 participants