Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(ui): ensure issue urls use tmdb id #329

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

In some cases, the IMDB id is used for the issue URL instead of the TMDB. ThemerrDB only accepts TMDB ids, so this PR nullifies issue URLs for items where the TMDB cannot be determined.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a22784) 69.87% compared to head (d988603) 69.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   69.87%   69.84%   -0.04%     
==========================================
  Files          12       12              
  Lines         986      985       -1     
==========================================
- Hits          689      688       -1     
  Misses        297      297              
Flag Coverage Δ
Linux 69.84% <100.00%> (-0.04%) ⬇️
Windows 69.84% <100.00%> (-0.04%) ⬇️
macOS 69.64% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/webapp.py 66.46% <100.00%> (-0.20%) ⬇️

@ReenigneArcher ReenigneArcher force-pushed the fix(ui)-ensure-issue-urls-use-tmdb-id branch from 5e46859 to d119001 Compare January 16, 2024 00:24
@ReenigneArcher ReenigneArcher force-pushed the fix(ui)-ensure-issue-urls-use-tmdb-id branch from d119001 to d988603 Compare January 17, 2024 00:24
@ReenigneArcher ReenigneArcher merged commit 2753241 into master Jan 17, 2024
21 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(ui)-ensure-issue-urls-use-tmdb-id branch January 17, 2024 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue with ThemerrDB issue urls
1 participant