Flush commands when changing hotkeys on X11 #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently not every X11 connection flushes the commands automatically. However, it's really important for the hotkey changes to take effect immediately. We don't do anything else on the X11 connection, so the changes would be pending until the next hotkey changes or possibly even later. This additionally cleans up the implementation to not ungrab all keys every time a hotkey change happens. This should not affect the bug, but it did not seem like the right thing to do in general.
CryZe
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently not every X11 connection flushes the commands automatically. However, it's really important for the hotkey changes to take effect immediately. We don't do anything else on the X11 connection, so the changes would be pending until the next hotkey changes or possibly even later.
This additionally cleans up the implementation to not ungrab all keys every time a hotkey change happens. This should not affect the bug, but it did not seem like the right thing to do in general.