Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4732: White screen appears when clicking three dots button on animal profile page #3688

Conversation

SayakaOno
Copy link
Collaborator

@SayakaOno SayakaOno commented Feb 11, 2025

Description

Fix Single animal view

  • Header
    • Update WithStepperProgressBar to conditionally hide/show a header based on headerComponent.
    • Pass headerComponent: null to ContextForm from SingleAnimalView
  • Meatballs menu
    • Send the missing options prop to FloatingMenu
    • Fix forwardRef typing for Menu component props

Jira link: https://lite-farm.atlassian.net/browse/LF-4732

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno added the bug Something isn't working label Feb 11, 2025
@SayakaOno SayakaOno self-assigned this Feb 11, 2025
@SayakaOno SayakaOno requested review from a team as code owners February 11, 2025 19:25
@SayakaOno SayakaOno requested review from antsgar and Duncan-Brain and removed request for a team February 11, 2025 19:25
Copy link
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhhh so the crash had nothing to do with the form changes! It was from:

and I definitely approved that 😅 I was so focused on the tsc when I tested that PR I did not even start to look at the props for the ref (although honestly forwardRef typing makes me immediately check out anyway, it makes no sense to me 😭) Thank you for understanding and fixing 🙏

BUT @antsgar this is the second piece of evidence we have that your pre-commit eslint is not running 🤣 Did you definitely npm install in root? This was an unused variable and shouldn't have been commit-able. I tried checking out that PR branch and couldn't commit to it locally.

@SayakaOno
Copy link
Collaborator Author

Thank you Joyce! I thought I compared the diffs but definitely missed that prop 😂 (I can relate to that since I'm not even a fan of having to write forwardRef...)

@antsgar
Copy link
Collaborator

antsgar commented Feb 13, 2025

Lol I clearly did not understand the typing for forwardRef either -- I'm so sorry that PR turned out so messy! I think I did run npm install on root but there's definitely something off on my local. I'm setting up everything from scratch on the new laptop anyway though so hopefully that should get rid of whatever's going on. Thank you so much for fixing this @SayakaOno!

The only tiny change I'd add (can be in the next PR, we don't have to wait to merge this one) is to un-export FloatingMenuProps

@antsgar antsgar added this pull request to the merge queue Feb 13, 2025
Merged via the queue into integration with commit 832945b Feb 13, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants