Add docker support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
force-pushed
the
25-setup-docker
branch
2 times, most recently
from
5670cb3 to
ff388ea
Compare
sameersubudhi
requested changes
Feb 7, 2024
ishantiw
force-pushed
the
25-setup-docker
branch
2 times, most recently
from
8b1c3e0 to
a6e1b0c
Compare
shuse2
approved these changes
Feb 7, 2024
ishantiw
force-pushed
the
25-setup-docker
branch
from
5f76625 to
e01cb4f
Compare
sameersubudhi
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
LGTM by functionality 👍
We could optionally add documentation to the Makefile using somthing like: https://github.com/Songmu/make2help in #24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #25
How was it solved?
How was it tested?
docker build -t faultdetector .ormake docker-builddocker run faultdetectorormake docker-run