Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fault detector helper function #21

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Implement fault detector helper function #21

merged 4 commits into from
Feb 7, 2024

Conversation

Incede
Copy link
Member

@Incede Incede commented Jan 30, 2024 •
edited
Loading

What was the problem?

This PR resolves #5

How was it solved?

  • Implement helper function FindFirstUnfinalizedOutputIndex
  • Implement GetLatestBlockHeader (more efficient than GetLatestBlock)
  • Update casting via safer encoding.MustConvertBigIntToUint64

How was it tested?

Added unit tests

@Incede Incede self-assigned this Jan 30, 2024
@Incede Incede requested a review from nagdahimanshu January 31, 2024 10:50
ishantiw
ishantiw reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nagdahimanshu nagdahimanshu mentioned this pull request Feb 3, 2024
Merged
8 tasks
@Incede Incede marked this pull request as ready for review February 6, 2024 00:56
@Incede Incede requested review from hrmhatef and shuse2 February 6, 2024 00:56
@hrmhatef hrmhatef self-requested a review February 6, 2024 13:31
hrmhatef
hrmhatef approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@hrmhatef hrmhatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

nagdahimanshu
nagdahimanshu approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ishantiw
ishantiw approved these changes Feb 7, 2024
View reviewed changes
pkg/faultdetector/helper.go Show resolved Hide resolved
@ishantiw ishantiw merged commit c1dafa6 into main Feb 7, 2024
1 check passed
@ishantiw ishantiw deleted the 5-helper branch February 7, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagdahimanshu nagdahimanshu nagdahimanshu approved these changes

@hrmhatef hrmhatef hrmhatef approved these changes

@ishantiw ishantiw ishantiw approved these changes

@shuse2 shuse2 Awaiting requested review from shuse2

Assignees

@Incede Incede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Fault detector helper functions
4 participants
@Incede @ishantiw @hrmhatef @nagdahimanshu