Add chain utils #12
Merged
Add chain utils #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
requested changes
Jan 17, 2024
hrmhatef
requested changes
Jan 17, 2024
shuse2
reviewed
Jan 18, 2024
shuse2
reviewed
Jan 18, 2024
ishantiw
force-pushed
the
4-chain-util
branch
from
64adca9 to
b9311d4
Compare
shuse2
requested changes
Jan 18, 2024
shuse2
approved these changes
Jan 18, 2024
hrmhatef
requested changes
Jan 18, 2024
pkg/chain/chain.go
Outdated
| log log.Logger | ||
| } | ||
|
|
||
| type proofResponse struct { |
There was a problem hiding this comment.
I think, it can be exposable struct in this pkg for the future use cases. we want to compare the result of GetProof func so it would be better to accessible outside of the chain pkg, is it correct?
There was a problem hiding this comment.
In the end we are going to use storageHash value from the proof, but yes maybe its better to make it accessible when a user will call this func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4
How was it solved?
How was it tested?
make test