Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI #5

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Update UI #5

merged 8 commits into from
Jun 19, 2024

Conversation

nagdahimanshu
Copy link
Member

@nagdahimanshu nagdahimanshu commented Jun 18, 2024 •
edited
Loading

What was the problem?

This PR resolves #2 #4

How was it solved?

  • Update UI
  • Update readme to make generic ERC20 faucet
  • Add Makefile
  • Enable CI
  • Fix existing unit test
  • Add unit tests
    • LSKtoWei
    • TransferERC20
    • addLeftPadding

How was it tested?

Local + CI

@nagdahimanshu nagdahimanshu self-assigned this Jun 18, 2024
@nagdahimanshu nagdahimanshu force-pushed the 2-update-ui branch 2 times, most recently from e119b1b to 6599823 Compare June 18, 2024 12:45
@nagdahimanshu nagdahimanshu marked this pull request as ready for review June 18, 2024 13:30
hrmhatef
hrmhatef requested changes Jun 18, 2024
View reviewed changes
Copy link

@hrmhatef hrmhatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small suggestion: skip-dirs is deprecated and we should use exclude-dirs based in the documents of the golangci-lint here

sameersubudhi
sameersubudhi requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@sameersubudhi sameersubudhi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. But could you please clarify/look at the following doubts/recommendations? 🙏

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
internal/chain/util_test.go Outdated Show resolved Hide resolved
internal/chain/util_test.go Outdated Show resolved Hide resolved
web/src/Faucet.svelte Outdated Show resolved Hide resolved
sameersubudhi
sameersubudhi approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM 👍
As discussed, let's create a separate PR for the unit test for TransferERC20 method.

@nagdahimanshu nagdahimanshu requested a review from hrmhatef June 19, 2024 12:38
hrmhatef
hrmhatef approved these changes Jun 19, 2024
View reviewed changes
Copy link

@hrmhatef hrmhatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nagdahimanshu nagdahimanshu merged commit 465997e into main Jun 19, 2024
1 check passed
@nagdahimanshu nagdahimanshu deleted the 2-update-ui branch June 19, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrmhatef hrmhatef hrmhatef approved these changes

@sameersubudhi sameersubudhi sameersubudhi approved these changes

Assignees

@nagdahimanshu nagdahimanshu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update UI
3 participants
@nagdahimanshu @sameersubudhi @hrmhatef