Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarted docker containers do not resume from the last synced state #21

Conversation

sameersubudhi
Copy link
Member

@sameersubudhi sameersubudhi commented Jul 16, 2024

What was the problem?

This PR partially resolves #19

  • The issue now only occurs if the op-geth node has not synced to a safe block yet (sync height less than ~18k); this will be addressed in a separate PR
  • The issue now doesn't occur if the op-geth node is past a safe block

How was it solved?

  • Do not initialize geth datadir, if already exists
  • Fix op-node start command; removed the commented flag that made subsequent flags getting ignored by the start command
  • Used default RPC port for op-node to avoid confusion with the sync status check command when running node with docker/source
  • Added static peer for op-node to ensure better p2p connectivity
  • Updated the default JWT token
  • Cleanup node start command in op-node-entrypoint to remove redundant flags already made available via the environment variables

How was it tested?

Locally against the mainnet

@sameersubudhi sameersubudhi self-assigned this Jul 16, 2024
@sameersubudhi sameersubudhi marked this pull request as draft July 17, 2024 06:02
@sameersubudhi sameersubudhi force-pushed the 19-restarted-docker-containers-do-not-resume-from-the-last-synced-state branch from 5db4939 to 1d212a8 Compare August 1, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restarted docker containers do not resume from the last synced state
1 participant