Indicate unclaimed rewards #5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManuGowda
suggested changes
Jun 28, 2023
src/modules/pos/validator/components/StakeSummary/StakeSummary.test.js
Outdated
Show resolved
Hide resolved
|
@eniolam1000752 can't we display each element in 1 row? otherwise it can be difficult to view the changes. |
src/modules/transaction/components/StakeValidate/StakeValidator.js
Outdated
Show resolved
Hide resolved
| serviceUrl: mainChainNetwork.serviceUrl, | ||
| }) | ||
| ); | ||
| setIsLoading(true); |
There was a problem hiding this comment.
Do we need to call setIsLoading(true) twice in this function? See line 176 as well
| @@ -231,9 +284,9 @@ const StakeForm = ({ t, stakes, account, isStakingTxPending, nextStep, history, | |||
| /> | |||
There was a problem hiding this comment.
Not related to this line:
Maybe we should rename the buttonTitle label to
buttonTitle={showEmptyState ? t('Continue to validator list') : t('Continue')}
Since that seems to be where it is navigating.
I dont know in which scenario we show this component when showEmptyState. Do you know how to test that flow?
ManuGowda
reviewed
Jun 29, 2023
src/modules/transaction/components/StakeValidate/StakeValidator.js
Outdated
Show resolved
Hide resolved
| </div> | ||
| {/* <div className={styles.txFeeContainer}> |
There was a problem hiding this comment.
It was a dead code.. i checked the UI the transaction fees are showned.
oskarleonard
approved these changes
Jun 29, 2023
ManuGowda
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5064
How was it solved?
How was it tested?
Continebutton