Add SwapAndBridge feature #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matjazv
requested changes
Mar 19, 2024
matjazv
requested changes
Mar 24, 2024
matjazv
requested changes
Apr 10, 2024
matjazv
requested changes
Apr 17, 2024
|
Two other things to consider:
|
…s in constructor, and add slippage check
…s in constructor, and add slippage check
v0.0.180
matjazv
reviewed
Jul 1, 2024
matjazv
approved these changes
Jul 2, 2024
matjazv
approved these changes
Jul 3, 2024
Co-authored-by: Matjaz Verbole <[email protected]>
gkoumout
approved these changes
Jul 9, 2024
gkoumout
reviewed
Jul 10, 2024
gkoumout
reviewed
Jul 10, 2024
gkoumout
reviewed
Jul 10, 2024
gkoumout
reviewed
Jul 10, 2024
…cts into feature/swapAndBridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191.
Implement swap-and-bridge feature with the
SwapAndBridgecontract. This contract exposes theswapAndBridgeToWithMinimumAmountpublic function by which users can swap ETH for a target LST and bridge it directly to an L2 while also specifying the minimum amount of LST to receive. The contract also exposes some convenience functions and a receive fallback allowing the interaction to happen just by sending ETH to the contract.A new
SwapAndBridgecontract should be deployed for each LST protocol and target L2. The contract will be created with the L1 LST token, the L1 bridge, and the target L2 token as parameters. In this PR we add integration tests for Lido and Diva LST protocols as examples.