Add script to deploy OptimismMintableERC20 USDT token using OptimismMintableERC20Factory #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
requested changes
Jun 5, 2024
shuse2
requested changes
Jun 5, 2024
ricott1
reviewed
Jun 5, 2024
Incede
changed the title
ricott1
reviewed
Jun 5, 2024
matjazv
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Except @ricott1 comment about extra cd ../ it looks fine!
The only question I have is if we want to automatically save newly deployed contract address somewhere like we do it for other contracts? (eg. deployment/testnet/l2addresses.json)
The thing is most of the times (atleast on Lisk Sepolia) |
Incede
force-pushed
the
154-factory-script
branch
from
c05b436
to
c61581c
Compare
shuse2
approved these changes
Jun 5, 2024
ricott1
approved these changes
Jun 5, 2024
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #153
How was it solved?
Added script with environment variable for testnet and mainnet
How was it tested?
bash 6_deployUSDTContract.sh--nonceflag to specify the correct nonce in the command in script, in case there is a nonce mismatch reported