Adds assertions to verify rewards contract balance, rewards surplus and weight #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has5aan
changed the title
matjazv
force-pushed
the
feature/improvements-and-recommendations
branch
from
98cfef1
to
07b3d82
Compare
has5aan
force-pushed
the
128
branch
2 times, most recently
from
c56b1e0
to
29af93c
Compare
has5aan
changed the title
has5aan
changed the base branch from
feature/improvements-and-recommendations
to
development
has5aan
changed the base branch from
development
to
feature/improvements-and-recommendations
has5aan
changed the title
gkoumout
reviewed
Jun 21, 2024
matjazv
force-pushed
the
feature/improvements-and-recommendations
branch
from
48b2eba
to
24e88be
Compare
gkoumout
reviewed
Jun 21, 2024
refactor: merge all tests for scenario1 into test_scenario1 refactor: merge all tests for scenario1 into test_scenario1
…enario2 and scenario3
…kConsistencyTotalWeight
gkoumout
reviewed
Jun 27, 2024
gkoumout
approved these changes
Jun 27, 2024
matjazv
merged commit 2183bf3
into
feature/improvements-and-recommendations
3 checks passed
matjazv
pushed a commit
that referenced
this pull request
Jun 28, 2024
…nd weight (#144) * Refactors scenarios * refactor: test_scenario1_dailyRewards * refactor: merge all tests for scenario1 into test_scenario1 refactor: merge all tests for scenario1 into test_scenario1 refactor: merge all tests for scenario1 into test_scenario1 * Adds checkRewardsContractBalance * refactor: removes redundant pending unlock amount test methods for scenario2 and scenario3 * refactor: moves the logic from scenario2_dailyRewards to scenario2 * refactor: moves the logic from scenario3_dailyRewards to scenario3 * add scenario4 to test surplus and reward contract balance * Reverts L2Reward * Adds more complex assertions to scenario4 regarding surplus verification * adds checkConsistencyTotalWeight * adds zero value check for amount and duration when adding rewards * added stakerClaimOnDayAndCheckConsistencyTotalWeight and removed checkConsistencyTotalWeight * test consistency of total weight and daily weights * updates scenario2 and scenario3 to check reward contract balance * refactors and adds docs * resolves compiler warnings * adds documentation to assertion functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves issues:
How was it solved?
Added
checkRewardsContractBalanceto verify that rewards contract balance after all stakes claim rewards at a day is equal to funds - sum of dailyRewards from 1st day to yesterday.Added
verifyRewardsSurplusForLockedAmountBetweenDaysto verify reward surplus amount.Added
checkConsistencyTotalWeightto verify that at all times totalWeight is the sum of daily weights and it is zero if all positions are expired or greater than zero if at least one position is active.Added checks to verify zero values for amount and duration for
fundStakingRewards,addUnusedRewardsand_addRewards.Refactored scenarios.