New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Lisk L1 token smart contract #13

Merged

shuse2 merged 44 commits into main from 3_l1_token

Jan 10, 2024

Member

has5aan commented Dec 12, 2023 •

edited

Loading

What was the problem?

This PR resolves #3

How was it solved?

Implemented L1LiskToken contract that can be owned, it allows to make approvals using signatures and maintains burner account that can burn tokens.

How was it tested?

Implemented unit tests.

has5aan self-assigned this

has5aan requested review from matjazv, AndreasKendziorra and sergeyshemyakov and removed request for AndreasKendziorra

December 12, 2023 14:31

matjazv requested changes

View reviewed changes

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

matjazv changed the title ~~L1LiskToken~~ Implement Lisk L1 token smart contract

matjazv requested changes

View reviewed changes

test/L1/L1LiskToken.t.sol Outdated Show resolved Hide resolved

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

matjazv requested changes

View reviewed changes

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

Contributor

matjazv commented Dec 14, 2023

And btw, could you increase total supply to 300 million? Because this is the latest amount which we would like to mint.

matjazv requested changes

View reviewed changes

script/L1LiskToken.s.sol Outdated Show resolved Hide resolved

script/L1LiskToken.s.sol Show resolved Hide resolved

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

matjazv requested changes

View reviewed changes

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

matjazv requested changes

View reviewed changes

script/L1LiskToken.s.sol Outdated Show resolved Hide resolved

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

test/L1/L1LiskToken.t.sol Outdated Show resolved Hide resolved

test/L1/L1LiskToken.t.sol Show resolved Hide resolved

test/L1/L1LiskToken.t.sol Outdated Show resolved Hide resolved

matjazv requested changes

View reviewed changes

src/L1/L1LiskToken.sol Show resolved Hide resolved

script/L1LiskToken.s.sol Show resolved Hide resolved

matjazv requested changes

View reviewed changes

src/L1/L1LiskToken.sol Show resolved Hide resolved

test/L1/L1LiskToken.t.sol Outdated Show resolved Hide resolved

src/L1/L1LiskToken.sol Show resolved Hide resolved

src/L1/L1LiskToken.sol Show resolved Hide resolved

src/L1/L1LiskToken.sol Show resolved Hide resolved

test/L1/L1LiskToken.t.sol Show resolved Hide resolved

test/L1/L1LiskToken.t.sol Show resolved Hide resolved

test/L1/L1LiskToken.t.sol Show resolved Hide resolved

matjazv mentioned this pull request

Implement L2 Claim Contract #8

Merged

has5aan force-pushed the 3_l1_token branch from 66b1498 to a79933b Compare

December 22, 2023 11:36

matjazv requested changes

View reviewed changes

script/L1LiskToken.s.sol Outdated Show resolved Hide resolved

script/L1LiskToken.s.sol Show resolved Hide resolved

script/L1LiskToken.s.sol Outdated Show resolved Hide resolved

test/L1/L1LiskToken.t.sol Outdated Show resolved Hide resolved

matjazv requested changes

View reviewed changes

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

matjazv requested changes

View reviewed changes

Contributor

matjazv left a comment

Other than a small change it looks good to me.
And a branch is outdated.

has5aan added 10 commits

January 4, 2024 21:09


          L1LiskToken is ERC20 contract

6b35c96


          Unauthorized error

7904a6c


          Ownable contract

4f505ab


          L1LiskToken is Ownable

e2b8c11


          forge install: openzeppelin-solidity

b1151d2

solc-nightly


          BurnerRole contract

6eb0c72


          L1LiskToken maintains burners through BurnerRole contract

5c30171


          L1LiskToken allows burners to burn their tokens

b6d575c


          L1LiskToken is ERC20Permit contract

60621e0


          L1LiskToken is Ownable from openzeppelin-contracts

dd5c930

has5aan and others added 19 commits

January 4, 2024 21:09


          Increases total supply to 300 million

bdc73b7


          Adds transferOwnership

804a7f6


          Verifies if deployer is owner and not a burner and total supply is 30…

ba9c005

…0 million


          ♻️ L1LiskToken declarations

c9fce59


          ♻️ Replaces _msgSender() with msg.sender

67eef49


          ♻️ Sets DEFAULT_ADMIN_ROLE as the roleAdmin for BURNER_ROLE

49105cd


          ♻️ Removes getBurnerRole() for BURNER_ROLE() ✅ Removes defaultAdminRo…

662aee8

…le for DEFAULT_ADMIN_ROLE()


          ✅ Adds assertions for test_Initialize

f7204c3


          ✅ Owner is not a burner

9c01f79


          ♻️ ✅ Rearranges imports

2885e7e


          ✅ Adds assertions

7c74f1b


          ✅ Only burner can burn from an account

1ba3adf


          Transfers ownership of L1LiskToken contract to configured address aft…

59fbf75

…er deployment


          ♻️ ✅ 🔥 Removes duplicate SigUtils

b0a4ad4


          Updates script/L1LiskToken.s.sol

16f1960

Co-authored-by: Matjaz Verbole <[email protected]>


          ♻️ L1LiskToken script

604bffe


          ♻️ ✅ Renames test methods for L1LiskToken

0ccbbb9


          📝 L1LiskToken

0abcdac


          📝 Updates renounceBurner NatSpec.

96100b5

Co-authored-by: Matjaz Verbole <[email protected]>

has5aan force-pushed the 3_l1_token branch from 3f09b11 to 96100b5 Compare

January 4, 2024 20:13

matjazv approved these changes

View reviewed changes

Contributor

matjazv left a comment

Only a small comment left.

Very good job! 🚀

script/L1LiskToken.s.sol Show resolved Hide resolved


          📝 L1LiskTokenScript

3b3c34a

matjazv approved these changes

View reviewed changes

script/L1LiskToken.s.sol Outdated Show resolved Hide resolved

has5aan and others added 2 commits

January 5, 2024 09:25


          📝 L1LiskTokenScript

8d9340b

Co-authored-by: Matjaz Verbole <[email protected]>


          📝 L1LiskTokenScript

0c34706

sergeyshemyakov approved these changes

View reviewed changes

Contributor

sergeyshemyakov left a comment

I have just two comments, otherwise the PR looks good

src/L1/L1LiskToken.sol Outdated Show resolved Hide resolved

test/L1/L1LiskToken.t.sol Show resolved Hide resolved


          ♻️ Removes call to _setRoleAdmin in ERC20 constructor

2c02f71

shuse2 enabled auto-merge (squash)

January 10, 2024 08:33

shuse2 merged commit cb55515 into main

3 checks passed

shuse2 deleted the 3_l1_token branch

January 10, 2024 08:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet