Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permit functionality to the Lisk L2 token #11

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Add permit functionality to the Lisk L2 token #11

merged 4 commits into from
Dec 20, 2023

Conversation

matjazv
Copy link
Contributor

@matjazv matjazv commented Nov 28, 2023

What was the problem?

How was it solved?

  • Lisk L2 token inherits ERC20Permit smart contract.
  • New unit tests were implemented.
  • File mode on script files was changed (to 755).

How was it tested?

  • All old and new unit tests passed.

@matjazv matjazv self-assigned this Nov 28, 2023
@Phanco Phanco self-requested a review November 28, 2023 17:36
Phanco
Phanco reviewed Dec 13, 2023
View reviewed changes
test/L2/L2LiskToken.t.sol Outdated Show resolved Hide resolved
Phanco
Phanco reviewed Dec 13, 2023
View reviewed changes
test/L2/L2LiskToken.t.sol Outdated Show resolved Hide resolved
Phanco
Phanco reviewed Dec 13, 2023
View reviewed changes
test/SigUtils.sol Outdated Show resolved Hide resolved
@matjazv matjazv requested a review from Phanco December 13, 2023 12:51
Phanco
Phanco reviewed Dec 13, 2023
View reviewed changes
test/L2/L2LiskToken.t.sol Outdated Show resolved Hide resolved
Phanco
Phanco approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@Phanco Phanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are really well written 👍

sergeyshemyakov
sergeyshemyakov approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@sergeyshemyakov sergeyshemyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good PR! I think it all should work nicely, also the test coverage is thorough.
I have left couple of comments for discussion, but generally I accept the PR.

test/L2/L2LiskToken.t.sol Show resolved Hide resolved
test/L2/L2LiskToken.t.sol Show resolved Hide resolved
@shuse2 shuse2 merged commit f7c8b10 into main Dec 20, 2023
3 checks passed
@shuse2 shuse2 deleted the 10-lisk-l2-token-permit branch December 20, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phanco Phanco Phanco approved these changes

@sergeyshemyakov sergeyshemyakov sergeyshemyakov approved these changes

@shuse2 shuse2 shuse2 approved these changes

Assignees

@matjazv matjazv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support permit functionality for Lisk L2 token
4 participants
@matjazv @shuse2 @Phanco @sergeyshemyakov