Modify JS file to comply with the new data structure #24
+118
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KilMer56
reviewed
Aug 19, 2024
Comment on lines
497
to
499
| // radiantPicks = "{{MatchSeries/Picks"; | ||
| radiantPicks = result.heroVeto.radiant.picks; | ||
| // radiantPicks += "}}\n"; |
There was a problem hiding this comment.
They are comments, probably not...
|
We don't have team names, we might want to fix that or it's hard to use in the popup. We can get that from the Valve API like Adding this should be worthwhile. |
|
I've removed the comments, added team names instead of ids and changed a bit of the api parsing style due to change in the structure of data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the JS used in the editor toolbar that inputs bracket data into the editor to comply with the new SAP API's data structure.