Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View All crops page #24

Closed

Conversation

crystalgardner
Copy link
Collaborator

@crystalgardner crystalgardner commented Nov 14, 2022

Describe at a high level the solution you're providing
Updated View all Crops page to reflect the most recent designs

Is this a patch, a minor version change, or a major version change
major

Is this related to an open issue?
Please provide the link.
#17

Additional context
Add any other technical detail or considerations here.
Last irrigated date is not yet implemented

@crystalgardner crystalgardner marked this pull request as draft November 14, 2022 14:24
@crystalgardner crystalgardner changed the title View All crops module initial setup View All crops page Dec 7, 2022
@crystalgardner crystalgardner marked this pull request as ready for review December 7, 2022 05:59
<button class="measureButton" mat-icon-button (click)="onViewCropAdvice(crop)">
MEASURE
</button>
<button mat-icon-button (click)="onViewCropAdvice(crop)">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can leave the "edit button click" as TODO since the design hasn't been finished yet

Copy link
Collaborator

@ilfreedom ilfreedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you squash your commits?

Use camel case class names for consistency

Adding header title bar component

fix review comment Liquid-Prep#22

Adding seed-date component to test header-title

implement liquid-prep header

Add design fixes / Planted date

Style fixes

style fixes

Leave edit button as TODO until design is complete
@crystalgardner
Copy link
Collaborator Author

Replaced by #27 (squashed commits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants