-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View All crops page #24
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystalgardner
changed the title
View All crops module initial setup
View All crops page
Dec 7, 2022
ilfreedom
reviewed
Dec 16, 2022
<button class="measureButton" mat-icon-button (click)="onViewCropAdvice(crop)"> | ||
MEASURE | ||
</button> | ||
<button mat-icon-button (click)="onViewCropAdvice(crop)"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can leave the "edit button click" as TODO since the design hasn't been finished yet
ilfreedom
reviewed
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you squash your commits?
Use camel case class names for consistency Adding header title bar component fix review comment Liquid-Prep#22 Adding seed-date component to test header-title implement liquid-prep header Add design fixes / Planted date Style fixes style fixes Leave edit button as TODO until design is complete
Replaced by #27 (squashed commits) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe at a high level the solution you're providing
Updated View all Crops page to reflect the most recent designs
Is this a patch, a minor version change, or a major version change
major
Is this related to an open issue?
Please provide the link.
#17
Additional context
Add any other technical detail or considerations here.
Last irrigated date is not yet implemented