Introducing LowLevelSerialization #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am adding both @enikao and @dslmeinte as reviewers: I think one review would be sufficient so I think once we got one in it is not strictly needed to have also the other one |
|
Big PR! It looks good. The tests (in this repo) seem to be failing currently, though. |
|
Yes, it is a big PR, but I obtained by splitting the original PR in three parts :D This was the second one of the three and third one is coming next. The tests are failing because I need to open a separate PR for the changes in the high-level serialization class. With the next PR all tests should be passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we introduce the LowLevelSerialization. It is intended to load semantically invalid/incoherent chunks and it is an intermediate rappresentation between the "proper" models and metamodels and the JSON representation.
This PR includes an update of all examples.
Some tests are still failing and they will be corrected as part of the remaining PR to finish up #46