-
Notifications
You must be signed in to change notification settings - Fork 2
integrate C# tests #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
enikao
wants to merge
4
commits into
master
Choose a base branch
from
niko/integrate-csharp-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
integrate C# tests #158
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7d5c114
added dynamic ContainmentTests_Annotation (translated from C#)
1698f28
added dynamic ContainmentTests_Multiple_Optional (translated from C#)
5dab2c5
added remaining dynamic tests (translated from C#)
cd9d2d2
trial to add generated Kotlin classes and first test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
43 changes: 43 additions & 0 deletions
43
core/src/test/java/examples/shapes/dynamic/ShapesDynamic.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
// Copyright 2024 TRUMPF Laser SE and other contributors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
// SPDX-FileCopyrightText: 2024 TRUMPF Laser SE and other contributors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package examples.shapes.dynamic; | ||
|
||
import io.lionweb.lioncore.java.serialization.JsonSerialization; | ||
|
||
import java.io.IOException; | ||
import java.io.InputStream; | ||
|
||
/** | ||
* Entrypoint for working with the Shapes example language. | ||
*/ | ||
public class ShapesDynamic { | ||
public static final io.lionweb.lioncore.java.language.Language Language; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above, simplify Search+Replace |
||
|
||
static { | ||
try (InputStream inputStream = ShapesDynamic.class.getResourceAsStream("/languages/defChunks/shapes.json")) { | ||
Language = JsonSerialization | ||
.getStandardSerialization() | ||
.loadLanguage(inputStream); | ||
} catch (IOException e) { | ||
throw new RuntimeException(e); | ||
} | ||
} | ||
|
||
// public static final INodeFactory Factory = Language.getFactory(); | ||
} | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these binary
.class
files here? Are these generated directly to bytecode by Kolasu? Is documented how these files are generated?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they are from Kolasu. Currently only playing around (see my open question to Federico). Once I understand how they're supposed to integrate with LW we can think of a proper way to do this.
In any case, I don't want to include any Kotlin code in this project -- would make it harder for others to consume and understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points. I wouldn't mind seeing a line or 2 about this in some documentation—if even it's just saying “generated by Kolasu, instructions might come” or something.