Skip to content

Improve Scikit-learn compatibility and use Self type annotation in the return of fit methods #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

msamsami
Copy link
Contributor

  • Add typing-extensions dependency for Python < 3.11 to support the Self type annotation
  • Replace string type hints with proper Self return type annotations in the fit methods of SEFR and LinearBoostClassifier classes
  • Update documentation to clarify scikit-learn version compatibility (1.4, 1.6+)
  • Add warning filtering for scikit-learn 1.6+ deprecation notices for the algorithm parameter
  • Fix parameter constraints for algorithm based on scikit-learn version
  • Improve docstring formatting and accuracy for better API documentation

@hamidkm9 hamidkm9 merged commit 6cf5a95 into LinearBoost:main Apr 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants