Skip to content

Commit

Permalink
A few more inclusive language updates based on newer wordlist
Browse files Browse the repository at this point in the history
Based on:
  https://source.android.com/setup/contribute/respectful-code

#inclusivefixit

Bug: 161336379
Bug: 161896447
Test: art/test.py --host --64
Change-Id: I7e6362556136ce1a3085fffae7598104fa5bc56a
  • Loading branch information
ohodson committed Jul 29, 2020
1 parent 5880c77 commit 26ab270
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions libartbase/base/bit_vector.cc
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ bool BitVector::Union(const BitVector* src) {

EnsureSize(highest_bit);

// Paranoid: storage size should be big enough to hold this bit now.
// Check: storage size should be big enough to hold this bit now.
DCHECK_LT(static_cast<uint32_t> (highest_bit), storage_size_ * kWordBits);
}

Expand Down Expand Up @@ -186,7 +186,7 @@ bool BitVector::UnionIfNotIn(const BitVector* union_with, const BitVector* not_i
if (storage_size_ < union_with_size) {
EnsureSize(highest_bit);

// Paranoid: storage size should be big enough to hold this bit now.
// Check: storage size should be big enough to hold this bit now.
DCHECK_LT(static_cast<uint32_t> (highest_bit), storage_size_ * kWordBits);
}

Expand Down
2 changes: 1 addition & 1 deletion libdexfile/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ cc_defaults {
"external/dex_file_supp.cc",
],
cflags: ["-DSTATIC_LIB"],
// Using whole_static_libs here only as a "poor man's transitivity" kludge.
// Using whole_static_libs here only as an "approximate transitivity" kludge.
whole_static_libs: [
"libbase",
"liblog",
Expand Down
6 changes: 3 additions & 3 deletions openjdkjvmti/deopt_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -421,13 +421,13 @@ jvmtiError DeoptManager::AddDeoptimizeThreadMethods(art::ScopedObjectAccessUnche
if (target->IncrementForceInterpreterCount() == 1) {
struct DeoptClosure : public art::Closure {
public:
explicit DeoptClosure(DeoptManager* man) : man_(man) {}
explicit DeoptClosure(DeoptManager* manager) : manager_(manager) {}
void Run(art::Thread* self) override REQUIRES_SHARED(art::Locks::mutator_lock_) {
man_->DeoptimizeThread(self);
manager_->DeoptimizeThread(self);
}

private:
DeoptManager* man_;
DeoptManager* manager_;
};
DeoptClosure c(this);
target->RequestSynchronousCheckpoint(&c);
Expand Down
2 changes: 1 addition & 1 deletion runtime/base/mutex.h
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ class LOCKABLE Mutex : public BaseMutex {

int32_t get_contenders() {
// Result is guaranteed to include any contention added by this thread; otherwise approximate.
// Treat contenders as unsigned because we're paranoid about overflow; should never matter.
// Treat contenders as unsigned because we're concerned about overflow; should never matter.
return static_cast<uint32_t>(state_and_contenders_.load(std::memory_order_relaxed))
>> kContenderShift;
}
Expand Down
2 changes: 1 addition & 1 deletion runtime/linear_alloc.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace art {

class ArenaPool;

// TODO: Support freeing if we add poor man's class unloading.
// TODO: Support freeing if we add class unloading.
class LinearAlloc {
public:
explicit LinearAlloc(ArenaPool* pool);
Expand Down
8 changes: 4 additions & 4 deletions test/1959-redefine-object-instrument/src/Main.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public static void notifyBreakpointReached(Thread thr, Executable e, long l) {}

public static void doTest() throws Exception {
final Object lock = new Object();
Breakpoint.Manager man = new Breakpoint.Manager();
Breakpoint.Manager manager = new Breakpoint.Manager();
Breakpoint.startBreakpointWatch(
Main.class,
Main.class.getDeclaredMethod("notifyBreakpointReached", Thread.class, Executable.class, Long.TYPE),
Expand All @@ -56,15 +56,15 @@ public static void doTest() throws Exception {
}
});
// set the breakpoint.
man.setBreakpoint(Main.class.getDeclaredMethod("doNothing"), 0l);
manager.setBreakpoint(Main.class.getDeclaredMethod("doNothing"), 0l);
thr.start();
while (!started || thr.getState() != Thread.State.TIMED_WAITING);
// Redefine while thread is paused.
forceRedefine(Object.class, Thread.currentThread());
// Clear breakpoints.
man.clearAllBreakpoints();
manager.clearAllBreakpoints();
// set the breakpoint again.
man.setBreakpoint(Main.class.getDeclaredMethod("doNothing"), 0l);
manager.setBreakpoint(Main.class.getDeclaredMethod("doNothing"), 0l);
// Wakeup
synchronized(lock) {
lock.notifyAll();
Expand Down

0 comments on commit 26ab270

Please sign in to comment.