Replace use of snprintf POSIX only feature #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. However, I'd like to avoid introducing a new placeholder, ie. $1 instead of the familiar %s. |
mmc28a
added a commit
to mmc28a/vixl
that referenced
this pull request
Jan 24, 2025
Positional arguments to printf (eg. %1$s) are not allowed on Windows, so remove uses of this in the disassembler, replacing them with an extension to the existing NEONFormatDecoder class. Patch prompted by Linaro#122
|
Here's the alternative: #125 . I'd be interested to know if that works OK for you, as I don't have easy access to a Windows system. |
mmc28a
added a commit
that referenced
this pull request
Jan 29, 2025
Positional arguments to printf (eg. %1$s) are not allowed on Windows, so remove uses of this in the disassembler, replacing them with an extension to the existing NEONFormatDecoder class. Patch prompted by #122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The position arguments
%n$sis a feature that is not available windowsAs the minimum version supported by vixl is C++17 we can't use
std::format, so provide our own solution.