uadk: bugfix CE driver initialization problem

When using UADK provider, using the default business type TASK_MIX will cause driver initialization to fail. Analysis found that the CE driver will be initialized by fallback, and NULL will be passed to the input parameter during initialization. This NULL parameter will cause a segmentation fault during CE driver initialization. Therefore, initialization is skipped for NULL parameters in the CE driver. Signed-off-by: Longfang Liu <[email protected]> Signed-off-by: Qi Tao <[email protected]>
Linaro · Aug 12, 2024 · fe6638d · fe6638d
1 parent 4beed87
commit fe6638d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/drv/hash_mb/hash_mb.c b/drv/hash_mb/hash_mb.c
@@ -192,6 +192,10 @@ static int hash_mb_init(struct wd_alg_driver *drv, void *conf)
 	struct hash_mb_ctx *priv;
 	int ret;
 
+	/* Fallback init is NULL */
+	if (!drv || !conf)
+		return 0;
+
 	priv = malloc(sizeof(struct hash_mb_ctx));
 	if (!priv)
 		return -WD_ENOMEM;

diff --git a/drv/isa_ce_sm3.c b/drv/isa_ce_sm3.c
@@ -375,7 +375,11 @@ static int sm3_ce_drv_init(struct wd_alg_driver *drv, void *conf)
 	struct wd_ctx_config_internal *config = (struct wd_ctx_config_internal *)conf;
 	struct sm3_ce_drv_ctx *sctx = (struct sm3_ce_drv_ctx *)drv->priv;
 
-	config->epoll_en = false;
+	/* Fallback init is NULL */
+	if (!drv || !conf)
+		return 0;
+
+	config->epoll_en = 0;
 
 	/* return if already inited */
 	if (sctx)

diff --git a/drv/isa_ce_sm4.c b/drv/isa_ce_sm4.c
@@ -36,6 +36,10 @@ static int isa_ce_init(struct wd_alg_driver *drv, void *conf)
 	struct wd_ctx_config_internal *config = conf;
 	struct sm4_ce_drv_ctx *sctx = drv->priv;
 
+	/* Fallback init is NULL */
+	if (!drv || !conf)
+		return 0;
+
 	config->epoll_en = 0;
 	memcpy(&sctx->config, config, sizeof(struct wd_ctx_config_internal));