-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Hexagon DSP binaries recipe #674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package the Hexagon DSP binaries release. Upstream name 'dsp-binaries' is not distinctive enough, so prefix it with 'hexagon-'. Signed-off-by: Dmitry Baryshkov <[email protected]>
Pull in hexagon-dsp-binaries-foo packages by the firmware packagegroups in order to be able to provide FastRPC-related functionality. Signed-off-by: Dmitry Baryshkov <[email protected]>
Add Hexagon DSP packages to the BAD_RECOMMENDATIONS list to prevent them from being included into the initramfs. Signed-off-by: Dmitry Baryshkov <[email protected]>
Add Hexagon DSP packages to the BAD_RECOMMENDATIONS list to prevent them from being included into the initramfs. Signed-off-by: Dmitry Baryshkov <[email protected]>
Extract DSP binaries from Pixel's vendor image in order to support FastRPC on those devices. Package them into a separate package, but RRECOMMENT it from the main package. Signed-off-by: Dmitry Baryshkov <[email protected]>
In order to migrate from provided dspso.bin binaries to the new hexagon-dsp-binaries data modify the mount-dsp.sh script to bind-mount device-specific DSP binaries location to the /usr/lib/rfsa dir. Signed-off-by: Dmitry Baryshkov <[email protected]>
With the adspso.bin contents being provided by the hexagon-dsp-binaries recipe the BSP package becomes empty and can be completely removed from the layer. Signed-off-by: Dmitry Baryshkov <[email protected]>
With the DSP binaries now being a part of the hexagon-dsp-binaries package there is no need anymore to install the dspso.bin image. Signed-off-by: Dmitry Baryshkov <[email protected]>
With the dspso.bin contents being provided by the hexagon-dsp-binaries recipe the BSP package becomes empty and can be completely removed from the layer. Signed-off-by: Dmitry Baryshkov <[email protected]>
With the dspso.bin contents being provided by the hexagon-dsp-binaries recipe the BSP package becomes empty and can be completely removed from the layer. Signed-off-by: Dmitry Baryshkov <[email protected]>
With the dspso.bin contents being provided by the hexagon-dsp-binaries recipe the BSP package becomes empty and can be completely removed from the layer. Signed-off-by: Dmitry Baryshkov <[email protected]>
The BSP package for DB410c has been empty for quite a while, drop it completely. Signed-off-by: Dmitry Baryshkov <[email protected]>
Stop providing files for the dspso package, all users have been removed. Signed-off-by: Dmitry Baryshkov <[email protected]>
Now as the dspso packages have been removed completely, we can drop them from the image's BAD_RECOMMENDATIONS list. Signed-off-by: Dmitry Baryshkov <[email protected]>
Now as the dspso packages have been removed completely, we can drop them from the image's BAD_RECOMMENDATIONS list. Signed-off-by: Dmitry Baryshkov <[email protected]>
@adhudase @ricardosalveti @ndechesne unless there are any comments, I'd like to merge this. |
ricardosalveti
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make meta-qcom use new hexagon-dsp-binaries repository for the DSP binaries location. Bind-mounting the DSP location to
/usr/lib/rfsa
is a long-standing hack which should be dropped either when we switch the layer to using hexagonrpcd or when the fastrpc daemon gets support for specifying the location for the binaries.