Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects: lkft-android: include: Add defaults to metadata #318

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

stylesen
Copy link
Contributor

@stylesen stylesen commented Jan 1, 2024

Default to 'unknown' when a particular metadata parameter is unavailable.

Default to 'unknown' when a particular metadata parameter is unavailable.

Signed-off-by: Senthil Kumaran S <[email protected]>
@liuyq
Copy link
Contributor

liuyq commented Jan 2, 2024

@stylesen thanks for the change! LGTM

@liuyq
Copy link
Contributor

liuyq commented Jan 3, 2024

Hi, @roxell @bhcopeland
when you are online could you please help check and merge if no issues there.

@bhcopeland
Copy link
Member

I would go with null values when the value is unknown, then defining the word unknown. But apart from that LGTM

@stylesen
Copy link
Contributor Author

stylesen commented Jan 3, 2024

I would go with null values when the value is unknown, then defining the word unknown. But apart from that LGTM

@bhcopeland this is the same followed in lkft devices as seen here - https://github.com/Linaro/lava-test-plans/blob/master/lava_test_plans/projects/lkft/include/metadata.jinja2

@bhcopeland
Copy link
Member

@stylesen fair enough, lets push this through. Null should be set there, but lets keep it matched.

@bhcopeland bhcopeland merged commit 5272b8e into Linaro:master Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants