Update justification verification #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grigorov-Georgi
requested review from
Zurcusa,
osrib,
hMitov and
georg-getz
and removed request for
osrib
Zurcusa
approved these changes
Jan 30, 2025
| @@ -26,14 +30,23 @@ | |||
| @Log | |||
| @NoArgsConstructor(access = AccessLevel.PRIVATE) | |||
There was a problem hiding this comment.
Suggested change
| @NoArgsConstructor(access = AccessLevel.PRIVATE) | |
| @UtilityClass |
And then we can remove the static from flag from the methods.
| log.log(Level.WARNING, "Duplicated signature"); | ||
| return false; | ||
| } | ||
| seenPublicKeys.add(preCommit.getAuthorityPublicKey()); | ||
| seenPublicKeys.add(signedVote.getAuthorityPublicKey()); |
There was a problem hiding this comment.
As per Spec:
A valid justification must only contain up to one valid vote from each voter and must not contain more than two equivocatory votes from each voter.
We can group them up beforehand using https://www.baeldung.com/java-groupingby-collector. Then check if any of the keys have > 3 votes and return false directly instead of checking a seen list.
|
Zurcusa
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #655 & #648