403 process catchup request #722
Conversation
…hold when sending catch up request. Extracted handling and sending of catch up requests to GrandpaSetState.java
|
|
||
| private List<Authority> authorities; | ||
| private BigInteger disabledAuthority; | ||
| private BigInteger setId; | ||
|
|
||
| private final BlockState blockState; | ||
| private final RoundCache roundCache; | ||
| private GrandpaRound lastFinalizedRound; |
There was a problem hiding this comment.
Wouldn't it be easier to store BigInteger lastFinalizedRoundNumber instead of GrandpaRound lastFinalizedRound and then call lastFinalizedRound.getRoundNumber()?
There was a problem hiding this comment.
The lastFinalizedRound field should also be updated; I suggest setting it right after attemptToFinalizeAt() returns true or directly in the method itself.
There was a problem hiding this comment.
We arranged that lastFinalizedRound will be taken from db
…ing to catch up request.
There was a problem hiding this comment.
I don't think these are needed here. We can fully move the logic to the GrandpaSetState. The methods here do not bring any extra logic in the process.
| @@ -10,7 +11,8 @@ | |||
| @Data | |||
| @AllArgsConstructor | |||
| @NoArgsConstructor | |||
| public class CatchUpMessage { | |||
| @Builder(toBuilder = true) | |||
There was a problem hiding this comment.
Why do we need the toBuilder ?
| @@ -9,6 +10,7 @@ | |||
| @Data | |||
| @AllArgsConstructor | |||
| @NoArgsConstructor | |||
| @Builder(toBuilder = true) | |||
# Conflicts: # src/main/java/com/limechain/network/protocol/grandpa/GrandpaService.java
…e methods from WarpSyncState.java to GrandpaSetState.java.
….java and CatchUpReqMessage.java
|
Description
Fixes #403 >