Scheduled and Forced Authority Set Change Handling

[Grigorov-Georgi]

Description

• Change the place of the AuthoritySetChanges PriorityQueue and its methods for adding and handling from WarpSyncState to RoundState. I assume that the RoundState would be renamed to GrandpaSetState or something similar.
• Merge incrementSetId and resetRound methods in RoundState into startNewSet(List)
• Create FocedAuthoritySetChange and ScheduledAuthoritySetChange classes which extend AuthoritySetChange
• Add a comparator to AuthoritySetChange to return a ForceAuthoritySetChange object with priority over ScheduledAuthoritySetChange objects
• Change the delay type in the GrandpaConsensusMessage from long to BigInteger
• Handle the additional offset 'm' in ForcedAuthoritySetChange

Fixes #401

[georg-getz]

We had a discussion with the team about numeric types about 2 years ago. I think it was mostly because of Java's lack of unsigned values which forced us to save u32 into a long and u64 into a BigInteger. We then agreed that having all the values as BigInteger, although more memory consuming, is the direction we wanna go in to reduce the need for parsing when comparing and to increase readability. Writing this because you have switched the type of the offset in GRANDPA consensus message.

If you feel like this decision needs revisiting feel free.

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud