feat: Add lilynext flag #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the following changes:
lilynextflaglilynextflag in the solver, resource provider, run, and job creator commandsThis pull request adds a
lilynextfeature flag to the gate the new protocol while we implement and stabilize it. The flag is available globally and consumed by commands that may implement the new protocol.Test plan
Run the solver with the
lilynextflag:The solver should log a line at startup like:
Running the solver without the
lilynextflag should not log this line.The same should hold true for the resource provider, run command, and job creator proxy.
Details
We will need make the feature flag available throughout our code, wherever we implement new protocol.
Although we do not actively support the onchain job creator, we pass the flag to it because it shares functionality with the run command, so it may need it.
Related issues or PRs
Epic: https://github.com/Lilypad-Tech/internal/issues/407