-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Api support + updates to job creation flow #510
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
|
3 similar comments
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We could potentially skip the rate limiting tests so they show up as skipped in test reporting, but since we are following this up quickly let's go ahead.
Left one last comment and your signing key is showing unverified on the commits, so let's clear that up and get this merged!
Add Job Creator support endpoints to the Solver
Makes the following changes to support the API Flow + in preparation for mainnet smart contracts and job creation flow removes deal agreement requirements from the job creator side (still needs to be removed from the cli and resource provider) set deal state to agreed on match (the states need to be revised and rearchitected to match the new smart contracts and job creation flow) Supporting changes: Solver Adds update JobStates helper function to update states across JobOffers, ResourceOffers, and Deal objects in the database in liu of smart contract updates Adds support to parse empty skeleton deal acceptance transactions from the JobCreator CLI Lilypad CLI removes smart contract call to accept results Resource Provider removes smart contract call to post results. Without this with the new solver changes the resource provider does not update its resource offer until it reaches the mandatory condition in the control loop (every 10 minutes).
Adds a way to exempt ips from the solver rate limitter
Makes the following changes to support the API Flow + in preparation for mainnet smart contracts and job creation flow
/job_offers/{id}
Lets you fetch jobOffer information and deal status with a Job Offer ID
/job_offers/{id}/results
Lets you fetch the results for a job with a Job Offer ID