Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Api support + updates to job creation flow #510

Merged
merged 10 commits into from
Feb 11, 2025
Merged

feat: Api support + updates to job creation flow #510

merged 10 commits into from
Feb 11, 2025

Conversation

kelindi
Copy link
Contributor

@kelindi kelindi commented Feb 10, 2025

Makes the following changes to support the API Flow + in preparation for mainnet smart contracts and job creation flow

  • removes deal agreement requirements from the job creation flow
  • Adds the following routes to the solver:
    /job_offers/{id}
    Lets you fetch jobOffer information and deal status with a Job Offer ID
    /job_offers/{id}/results
    Lets you fetch the results for a job with a Job Offer ID

@kelindi kelindi self-assigned this Feb 10, 2025
@kelindi kelindi requested a review from a team as a code owner February 10, 2025 16:48
@cla-bot cla-bot bot added the cla-signed label Feb 10, 2025
@kelindi kelindi changed the title Feat: Api support + updates to job creation flow feat: Api support + updates to job creation flow Feb 10, 2025
Copy link

cla-bot bot commented Feb 10, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Feb 10, 2025
Copy link

cla-bot bot commented Feb 10, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

3 similar comments
Copy link

cla-bot bot commented Feb 10, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Feb 11, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Feb 11, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kelindi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We could potentially skip the rate limiting tests so they show up as skipped in test reporting, but since we are following this up quickly let's go ahead.

Left one last comment and your signing key is showing unverified on the commits, so let's clear that up and get this merged!

Add Job Creator support endpoints to the Solver
Makes the following changes to support the API Flow + in preparation for mainnet smart contracts and job creation flow

removes deal agreement requirements from the job creator side (still needs to be removed from the cli and resource provider)
set deal state to agreed on match (the states need to be revised and rearchitected to match the new smart contracts and job creation flow)
Supporting changes:

Solver

Adds update JobStates helper function to update states across JobOffers, ResourceOffers, and Deal objects in the database in liu of smart contract updates
Adds support to parse empty skeleton deal acceptance transactions from the JobCreator CLI
Lilypad CLI

removes smart contract call to accept results
Resource Provider

removes smart contract call to post results. Without this with the new solver changes the resource provider does not update its resource offer until it reaches the mandatory condition in the control loop (every 10 minutes).
Adds a way to exempt ips from the solver rate limitter
@kelindi kelindi merged commit eb9d218 into main Feb 11, 2025
5 checks passed
@kelindi kelindi deleted the api-net branch February 11, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants