Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve cuda pow #182

Merged
merged 3 commits into from
Jun 24, 2024
Merged

perf: improve cuda pow #182

merged 3 commits into from
Jun 24, 2024

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Jun 24, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)
  1. slight improve cuda speed about 10-15%
  2. change the difficulty to 8m hash expectation
  3. add owner permission function to change difficulty

Summary

Provide a one line summary and link to any relevant references

Task/Issue reference

Closes: add_link_here

Details (optional)

Add any additional details that might help Code Reviewers digest this PR

How to test this code? (optional)

Anything else? (optional)

@hunjixin hunjixin force-pushed the perf/imporve_cuda_speed branch from 7bce23b to d60438d Compare June 24, 2024 04:23
Copy link
Contributor

@richardbremner richardbremner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow most of the CUDA, but as long as you have tested it and the integration tests pass, go ahead

@hunjixin hunjixin merged commit fbaf86f into main Jun 24, 2024
2 checks passed
@hunjixin hunjixin deleted the perf/imporve_cuda_speed branch June 24, 2024 05:30
bgins pushed a commit that referenced this pull request Jun 25, 2024
* perf: improve cuda pow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants