limit the containers that can be executed #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgins
reviewed
Jun 10, 2024
bgins
reviewed
Jun 13, 2024
* feat: add geolocation data to websocket events * feat: add deals tracking (#151) * feat: add function to track deals * feat: add tracking deals * chore: fix typo
* Configuration update for Arbitrum * chore: remove file not part of PR * chore: remove settings that are not needed and set global defaults and consts * chore: refactor stack to simplify local chain clean, run and boot --------- Co-authored-by: Gorka <[email protected]>
* feat: power implementation * fix: blocked error channel --------- Co-authored-by: root <[email protected]>
* build: Rename solver, job creator, and contracts secrets * chore: Remove unused Cloudflare token and Doppler config * chore: Rename local_l2 to dev Matches other places where we refer to local development as dev. * fix: update network on run cmd * chore: Update print-env network, RPC URL, and chain ID * build: Remove Devnet contracts deploy job We have decided to rebuild the chain from scratch on Devnet. --------- Co-authored-by: Gorka <[email protected]>
* feat: power implementation * feat: simplly code * chore: add a explain comment for target difficulty * fix typo * fix: blocked error channel * chore: update dev toml sc address * feat: change wrong log and add toml tag * fix: upgrade cowsay to v0.0.4 * fix: update devent controller address * fix: Add POW config processor * feat: add pow address for testnet * chore: update to latest controller address * chore: update contract addresses * build: add hardhat testnet config --------- Co-authored-by: root <[email protected]> Co-authored-by: hunjixin <[email protected]> Co-authored-by: Brian Ginsburg <[email protected]> Co-authored-by: Gorka <[email protected]> Co-authored-by: Arsen Yeremin <[email protected]>
Co-authored-by: hunjixin <[email protected]>
noryev
force-pushed
the
module-allowlist-logan
branch
from
4bdca6f to
1520184
Compare
|
Closed in favor or issue #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
Limit the containers that can be executed on the jobcreator. Updates consist of a module allowlist fetch and allowlist check before deal agreement.
Task/Issue reference
Closes: #63
Details
Implemented into the jobcreator/controller.go due to controller managing job offers and doing the interaction with the solver on deal agreements. This includes the allowlist fetch using a simple http fetch to the lilypad-tech Github as well as the allowlist check function before a deal is agreed on.
How to test this code? (optional)
I am still having issues with my lilypad on-chain jobs in my local dev environment- please test as well!
Anything else? (optional)
I did a alias to the http package as to not step on the "github.com/lilypad-tech/lilypad/pkg/http" package