refactor: Move RunPreflightChecks function to preflight package

Co-authored-by: logan <[email protected]>
Lilypad-Tech · Feb 3, 2025 · 4582da5 · 4582da5
1 parent b6342c6
commit 4582da5
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 29 deletions.
diff --git a/pkg/resourceprovider/preflight/docker.go b/pkg/resourceprovider/preflight/docker.go
@@ -11,7 +11,7 @@ type dockerInfo struct {
 	Runtimes map[string]interface{} `json:"Runtimes"`
 }
 
-func (p *PreflightChecker) CheckDockerRuntime(ctx context.Context) CheckResult {
+func (p *preflightChecker) CheckDockerRuntime(ctx context.Context) CheckResult {
 	cmd := exec.CommandContext(ctx, "docker", "info", "--format", "{{json .}}")
 	output, err := cmd.Output()
 	if err != nil {

diff --git a/pkg/resourceprovider/preflight/gpu.go b/pkg/resourceprovider/preflight/gpu.go
@@ -73,7 +73,7 @@ func parseGPURecord(record string) (*GPUInfo, error) {
 	return gpu, nil
 }
 
-func (p *PreflightChecker) GetGPUInfo(ctx context.Context) ([]GPUInfo, error) {
+func (p *preflightChecker) GetGPUInfo(ctx context.Context) ([]GPUInfo, error) {
 	if err := checkNvidiaSMI(); err != nil {
 		return nil, fmt.Errorf("nvidia-smi not available: %w", err)
 	}
@@ -112,7 +112,7 @@ func (p *PreflightChecker) GetGPUInfo(ctx context.Context) ([]GPUInfo, error) {
 	return gpus, nil
 }
 
-func (p *PreflightChecker) CheckGPU(ctx context.Context, config *GPUCheckConfig) CheckResult {
+func (p *preflightChecker) CheckGPU(ctx context.Context, config *GPUCheckConfig) CheckResult {
 	if !config.Required {
 		// Attempt to retrieve GPU info
 		gpus, err := p.GetGPUInfo(ctx)

diff --git a/pkg/resourceprovider/preflight/preflight.go b/pkg/resourceprovider/preflight/preflight.go
@@ -3,6 +3,8 @@ package preflight
 import (
 	"context"
 	"fmt"
+
+	"github.com/rs/zerolog/log"
 )
 
 const RequiredGPUMemoryGB = 1 // 1GB of VRAM is required to startup if GPU is enabled
@@ -29,11 +31,34 @@ type PreflightConfig struct {
 	}
 }
 
-type PreflightChecker struct {
+type preflightChecker struct {
 	gpuInfo []GPUInfo
 }
 
-func (p *PreflightChecker) RunAllChecks(ctx context.Context, config PreflightConfig) error {
+func RunPreflightChecks(ctx context.Context, config PreflightConfig) error {
+	log.Info().Msg("Starting preflight checks...")
+	checker := &preflightChecker{}
+
+	// Logging GPU requirements
+	gpuInfo, err := checker.GetGPUInfo(ctx)
+	if err != nil {
+		log.Warn().Err(err).Msg("⚠️  No GPU detected - will operate in CPU-only mode")
+	} else {
+		log.Info().
+			Int("gpu_count", len(gpuInfo)).
+			Int64("min_memory_gb", config.GPU.MinMemoryGB).
+			Msg("🎮 GPU requirements")
+	}
+
+	err = checker.RunAllChecks(ctx, config)
+	if err != nil {
+		log.Error().Err(err).Msg("❌ Preflight checks failed")
+		return err
+	}
+	return nil
+}
+
+func (p *preflightChecker) RunAllChecks(ctx context.Context, config PreflightConfig) error {
 
 	gpuResult := p.CheckGPU(ctx, &GPUCheckConfig{
 		MinMemory: config.GPU.MinMemoryGB * 1024 * 1024 * 1024,

diff --git a/pkg/resourceprovider/resourceprovider.go b/pkg/resourceprovider/resourceprovider.go
@@ -90,7 +90,7 @@ func NewResourceProvider(
 	executor executor.Executor,
 	tracer trace.Tracer,
 ) (*ResourceProvider, error) {
-	if err := runPreflightChecks(context.Background(), options.Preflight); err != nil {
+	if err := preflight.RunPreflightChecks(context.Background(), options.Preflight); err != nil {
 		return nil, fmt.Errorf("preflight checks failed: %w", err)
 	}
 
@@ -108,29 +108,6 @@ func NewResourceProvider(
 	return solver, nil
 }
 
-func runPreflightChecks(ctx context.Context, config preflight.PreflightConfig) error {
-	log.Info().Msg("Starting preflight checks...")
-	checker := &preflight.PreflightChecker{}
-
-	// Logging GPU requirements
-	gpuInfo, err := checker.GetGPUInfo(ctx)
-	if err != nil {
-		log.Warn().Err(err).Msg("⚠️  No GPU detected - will operate in CPU-only mode")
-	} else {
-		log.Info().
-			Int("gpu_count", len(gpuInfo)).
-			Int64("min_memory_gb", config.GPU.MinMemoryGB).
-			Msg("🎮 GPU requirements")
-	}
-
-	err = checker.RunAllChecks(ctx, config)
-	if err != nil {
-		log.Error().Err(err).Msg("❌ Preflight checks failed")
-		return err
-	}
-	return nil
-}
-
 func (resourceProvider *ResourceProvider) Start(ctx context.Context, cm *system.CleanupManager) chan error {
 	if !resourceProvider.options.Pow.DisablePow {
 		if errCh := resourceProvider.StartMineLoop(ctx); errCh != nil {