Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop saying that we avoid a memory leak #168

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Stop saying that we avoid a memory leak #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions docs/src/explanations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,7 @@ A few reasons
- Chairmarks runs its arguments as functions in the scope that the benchmark was invoked
from, rather than `eval`ing them at global scope. This makes it possible to get
significant performance speedups for fast benchmarks by putting the benchmarking itself
into a function. It also avoids leaking memory on repeated invocations of a benchmark,
which is unavoidable with BenchmarkTools.jl's design.
([discourse](https://discourse.julialang.org/t/memory-leak-with-benchmarktools/31282),
[github](https://github.com/JuliaCI/BenchmarkTools.jl/issues/339))
into a function.
- Because Charimarks does not use toplevel eval, it can run arbitrarily quickly, as limited
by a user's noise tolerance. Consequently, the auto-tuning algorithm is tuned for low
runtime budgets in addition to high budgets so its precision doesn't degrade too much at
Expand Down
Loading