Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] #15 공통컴포넌트 Header 개발 #16

Closed
wants to merge 2 commits into from

Conversation

iam-hyo
Copy link
Collaborator

@iam-hyo iam-hyo commented Sep 20, 2024

🔍 What is the PR?

  • Header.jsx 생성. 매인 배너 부분
  • DateBar.jsx 생성. 날자 표기 버튼, 10/7일 이전에는 10/7일자가 디폴트

📸 Screenshot

image

📍 PR Point

여러명이서 비대면으로 협업 처음해보는데 브랜치 생성 잘했습니다~~
PR도 처음으로 열심히 적어보는데 열심히 적는 보람이 있습니다~~

📢 Notices

✅ Check List

  • Merge 하는 브랜치가 올바른가?
  • PR과 관련없는 변경사항이 없는가?
  • 내 코드에 대한 자기 검토가 되었는가?

💭 Related Issues

feature/#15

@nicerjs23 nicerjs23 self-requested a review September 21, 2024 01:33
Copy link
Collaborator

@nicerjs23 nicerjs23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 확인했습니다!! 수고하셨습니다~~

Copy link
Member

@sayyyho sayyyho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature/#15 공통컴포넌트 : Header #16

이 형식에서

[Feature] Header 공통 컴포넌트 구현으로 PR 규칙 지켜주세요!

추가적으로 아래 체크리스트 3개도 이행했으면 체크해주세요!

Copy link
Member

@sayyyho sayyyho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 부분 체크하신 뒤에 수정해주시고, 다시 커밋 후 병합해주세용!

src/App.jsx Show resolved Hide resolved
Comment on lines +3 to +31
import AppleSDGothicNeoH from "../assets/fonts/AppleSDGothicNeoH.ttf"
import AppleSDGothicNeoB from "../assets/fonts/AppleSDGothicNeoB.ttf"
import AppleSDGothicNeoL from "../assets/fonts/AppleSDGothicNeoL.ttf";


export const GlobalStyle = createGlobalStyle`
@font-face {
font-family: 'AppleSDGothicNeoH';
src: url(${AppleSDGothicNeoH}) format('truetype');
font-weight: 100;
font-style: normal;
}
@font-face {
font-family: 'AppleSDGothicNeoB';
src: url(${AppleSDGothicNeoB}) format('truetype');
font-weight: 100;
font-style: normal;
}
@font-face {
font-family: 'AppleSDGothicNeoL';
src: url(${AppleSDGothicNeoL}) format('truetype');
font-weight: 100;
font-style: normal;
}
h1{
font-family: 'AppleSDGothicNeoH';
font-weight: normal;
}
`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 제가 GlobalStyle.js과 theme.js에 설정했는데 한 번 더 사용하신 이유가 있을까요?
Notion에 사용법 공유드렸습니다!

@iam-hyo iam-hyo changed the title Feature/#15 공통컴포넌트 : Header [Feature] 공통컴포넌트 : Header 개발 Sep 21, 2024
@sayyyho sayyyho changed the title [Feature] 공통컴포넌트 : Header 개발 [Feature] 공통컴포넌트 Header 개발 Sep 22, 2024
@sayyyho sayyyho changed the title [Feature] 공통컴포넌트 Header 개발 [Feature] #15 공통컴포넌트 Header 개발 Sep 22, 2024
@sayyyho sayyyho added ✨ Feature 새 기능 구현 🎨 Design UI 디자인을 구현하거나 변경 🍂 효준 효준작업 labels Sep 22, 2024
@nicerjs23
Copy link
Collaborator

nicerjs23 commented Sep 24, 2024

혹시 이거 수정버전으로 다시 올리셔서 적용안할 PR이면 pr닫아도 될까요??

@nicerjs23 nicerjs23 closed this Sep 24, 2024
@nicerjs23 nicerjs23 reopened this Sep 24, 2024
@nicerjs23 nicerjs23 closed this Sep 24, 2024
@iam-hyo iam-hyo deleted the feature/#15 branch September 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 새 기능 구현 🍂 효준 효준작업 🎨 Design UI 디자인을 구현하거나 변경
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants