-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] #15 공통컴포넌트 Header 개발 #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 확인했습니다!! 수고하셨습니다~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 부분 체크하신 뒤에 수정해주시고, 다시 커밋 후 병합해주세용!
import AppleSDGothicNeoH from "../assets/fonts/AppleSDGothicNeoH.ttf" | ||
import AppleSDGothicNeoB from "../assets/fonts/AppleSDGothicNeoB.ttf" | ||
import AppleSDGothicNeoL from "../assets/fonts/AppleSDGothicNeoL.ttf"; | ||
|
||
|
||
export const GlobalStyle = createGlobalStyle` | ||
@font-face { | ||
font-family: 'AppleSDGothicNeoH'; | ||
src: url(${AppleSDGothicNeoH}) format('truetype'); | ||
font-weight: 100; | ||
font-style: normal; | ||
} | ||
@font-face { | ||
font-family: 'AppleSDGothicNeoB'; | ||
src: url(${AppleSDGothicNeoB}) format('truetype'); | ||
font-weight: 100; | ||
font-style: normal; | ||
} | ||
@font-face { | ||
font-family: 'AppleSDGothicNeoL'; | ||
src: url(${AppleSDGothicNeoL}) format('truetype'); | ||
font-weight: 100; | ||
font-style: normal; | ||
} | ||
h1{ | ||
font-family: 'AppleSDGothicNeoH'; | ||
font-weight: normal; | ||
} | ||
` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 제가 GlobalStyle.js과 theme.js에 설정했는데 한 번 더 사용하신 이유가 있을까요?
Notion에 사용법 공유드렸습니다!
혹시 이거 수정버전으로 다시 올리셔서 적용안할 PR이면 pr닫아도 될까요?? |
🔍 What is the PR?
📸 Screenshot
📍 PR Point
여러명이서 비대면으로 협업 처음해보는데 브랜치 생성 잘했습니다~~
PR도 처음으로 열심히 적어보는데 열심히 적는 보람이 있습니다~~
📢 Notices
✅ Check List
💭 Related Issues
feature/#15