Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change MAX_X5_LEN value to 13 #33

Merged
merged 1 commit into from
Oct 29, 2023
Merged

fix: Change MAX_X5_LEN value to 13 #33

merged 1 commit into from
Oct 29, 2023

Conversation

ananas-block
Copy link
Contributor

Issue:

  • the constant MAX_X5_LEN was still set to 16 even though the max implemented inputs are 13
  • this resulted in confusing error messages

Changes:

  • set MAX_X5_LEN = 13 (the currently implemented max width)
  • removed redundant test

@vadorovsky vadorovsky changed the title fix(poseidon): fixed MAX_X5_LEN value 13 fix: Change MAX_X5_LEN value to 13 Oct 29, 2023
@vadorovsky vadorovsky merged commit 7e33fd8 into main Oct 29, 2023
2 of 3 checks passed
@vadorovsky vadorovsky deleted the jorrit/fix-max_x5_len branch October 29, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ananas-block @vadorovsky