migrate to latest supported pydantic #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==================================
Coverage 86% 86%
==================================
Files 3 3
Lines 167 167
==================================
Hits 144 144
Misses 23 23 |
Borda
reviewed
Aug 26, 2024
| hivemind >=1.1.0, <=1.1.10.post2; sys_platform == 'linux' | ||
|
|
||
| pydantic <2.0.0 # fixme: lift when resolved | ||
| hivemind @ git+https://github.com/learning-at-home/hivemind.git@213bff98a62accb91f254e2afdccbf1d69ebdea9 |
There was a problem hiding this comment.
lets wait till this is fully released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR lifts the
pydantic < 2.0restriction. Hivemind was recently updated to support Pydantic v2, and this limitation is no longer necessary.I'm not sure why, but maintainers are not releasing PyPi packages anymore. If you look at the Petals source code, you'll see that they just point to the appropriate commit hash on Github; so, that's what I've done here, as well.
Let me know if you have any questions. Thanks!