feat: migrate to mocha 5 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Chai is the last package that isn't up to date with the latest versions
migrating chaiv4 to chai v5 is a breaking change but it allows us to be updated with all the security and vulnerability scans.
Tradeoff, chai v5 is only delivered through ESM modules.
This meant that references to chai would now need to be done via dynamic imports. This adds a beforeAll call on mocha hooks.
We cannot move the package out of commonjs until we further test the core-package's integration with sfdx. generating a module that is esnext or nodenext might break how we integrate with the sfdx package or the umd module or the package being generated for the vsce