Skip to content

Commit

Permalink
fix: backwards compatibility for cjs and new compatibility for umd
Browse files Browse the repository at this point in the history
  • Loading branch information
junners committed May 26, 2024
1 parent 42d6a31 commit 0355539
Show file tree
Hide file tree
Showing 4 changed files with 54 additions and 21 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"types": "index.d.ts",
"engines": {"node": "^18 || ^20"},
"scripts": {
"test": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' mocha -r ts-node/register tests/**/*.test.ts",
"build": "tsc",
"test": "TS_NODE_PROJECT=tsconfig.cjs.json mocha -r ts-node/register tests/**/*.test.ts",
"build": "tsc -p tsconfig.cjs.json",
"prepare": "husky",
"precommit": "lint-staged",
"lint": "eslint src",
Expand Down
42 changes: 24 additions & 18 deletions rollup.config.mjs
Original file line number Diff line number Diff line change
@@ -1,20 +1,26 @@
import typescript from '@rollup/plugin-typescript';
import nodePolyfills from 'rollup-plugin-polyfill-node';
import { nodeResolve } from '@rollup/plugin-node-resolve';
import commonjs from '@rollup/plugin-commonjs';
import typescript from "@rollup/plugin-typescript";
import nodePolyfills from "rollup-plugin-polyfill-node";
import { nodeResolve } from "@rollup/plugin-node-resolve";

export default {
input: "src/index.ts",
output: {
dir: "out",
format: 'umd',
name: 'lightningflowscanner',
sourcemap: true,
globals: {
"path-browserify": "p",
xmlbuilder2: "xmlbuilder2"
}
},
plugins: [nodePolyfills(), typescript(), nodeResolve({preferBuiltins:true}), nodePolyfills()],
external: ["path-browserify", "xmlbuilder2"]
}
input: "src/index.ts",
output: [
{
dir: "dist",
format: "umd",
name: "lightningflowscanner",
sourcemap: true,
globals: {
"path-browserify": "p",
xmlbuilder2: "xmlbuilder2",
},
}
],
plugins: [
nodePolyfills(),
typescript({tsconfig: `tsconfig.umd.json`}),
nodeResolve({ preferBuiltins: true }),
nodePolyfills(),
],
external: ["path-browserify", "xmlbuilder2"],
};
27 changes: 27 additions & 0 deletions tsconfig.cjs.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"compilerOptions": {
"module": "commonjs",
"target": "es6",
"resolveJsonModule": true,
"outDir": "out",
"lib": [
"es2020.string",
"es6"
],
"experimentalDecorators": true,
"sourceMap": true,
"rootDir": "src",
"strict": false, /* enable all strict type-checking options */
"baseUrl": ".",
"declaration": true,
"esModuleInterop": true
},
"exclude": [
"node_modules",
"out/**",
".idea/**",
"src/data/CustomRuleExample.ts",
"tests/**/*.test.ts"
]
}

2 changes: 1 addition & 1 deletion tsconfig.json → tsconfig.umd.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"module": "ESNext",
"target": "es6",
"outDir": "out",
"outDir": "dist",
"moduleResolution":"node",
"lib": [
"es2020.string",
Expand Down

0 comments on commit 0355539

Please sign in to comment.