Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: merge_state method #2786

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Feature: merge_state method #2786

wants to merge 11 commits into from

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 15, 2024

What does this PR do?

Fixes #2643
Seems most of the logic is already implemented in private methods so it is really just creating a public method + testing.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2786.org.readthedocs.build/en/2786/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Oct 15, 2024
@SkafteNicki SkafteNicki added this to the v1.5.0 milestone Oct 15, 2024
@SkafteNicki SkafteNicki marked this pull request as ready for review October 18, 2024 13:33
src/torchmetrics/metric.py Outdated Show resolved Hide resolved
src/torchmetrics/metric.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (7f579eb) to head (0a668f2).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2786   +/-   ##
======================================
- Coverage      70%     70%   -0%     
======================================
  Files         336     336           
  Lines       18235   18248   +13     
======================================
+ Hits        12709   12711    +2     
- Misses       5526    5537   +11     

@mergify mergify bot removed the has conflicts label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: Cluster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support equivalent of torcheval's merge_state
2 participants