-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/multiclass recall macro avg ignore index #2710
Open
rittik9
wants to merge
26
commits into
Lightning-AI:master
Choose a base branch
from
rittik9:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rittik9
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
September 1, 2024 20:46
Borda
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, can we add also test for this case...
Sure |
Borda
previously approved these changes
Sep 4, 2024
@Borda What do I have to modify? |
Borda
approved these changes
Sep 9, 2024
justusschock
approved these changes
Sep 10, 2024
@rittik9 mind checking the changed docstest values and whether it is correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2441
Details
Did you have fun?
Yes
Issue:
ignore_index
information is not being properly propagated to the final averaging step i.e. the_adjust_weights_safe_divide
function doesn't know that which class should be ignored.Solution:
ignore_index
information is preserved throughout the entire process, making sure it is correctly passed through all intermediate steps up to the final averaging stage i.e._adjust_weights_safe_divide
function ._adjust_weights_safe_divide
function to accept an additionalignore_index
parameter, which is passed through the_precision_recall_reduce
function, called in thecompute
method of theMulticlassRecall
class. This change adjusts the weights in the_adjust_weights_safe_divide
function, setting the weight of the ignored class to 0.📚 Documentation preview 📚: https://torchmetrics--2710.org.readthedocs.build/en/2710/