Skip to content

ci: debug failing run on master #20845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/checkgroup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,15 @@ subprojects:
- "lightning-fabric (GPUs) (testing Fabric | latest)"
- "lightning-fabric (GPUs) (testing Lightning | latest)"

- id: "lightning_fabric: TPU workflow"
paths:
# tpu CI availability is very limited, so we only require tpu tests
# to pass when their configurations are modified
- ".github/workflows/tpu-tests.yml"
- "tests/tests_fabric/run_tpu_tests.sh"
checks:
- "test-on-tpus (pytorch, pjrt, v4-8)"
# Temporarily disabled
# - id: "lightning_fabric: TPU workflow"
# paths:
# # tpu CI availability is very limited, so we only require tpu tests
# # to pass when their configurations are modified
# - ".github/workflows/tpu-tests.yml"
# - "tests/tests_fabric/run_tpu_tests.sh"
# checks:
# - "test-on-tpus (pytorch, pjrt, v4-8)"

# SECTION: common

Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/_legacy-checkpoints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,13 @@ jobs:
retention-days: ${{ env.KEEP_DAYS }}
include-hidden-files: true

- name: access secrets
# export to env bool if secrets.AWS_REGION is not empty
run: echo "WITH_SECRETS=$([ -n '${{ secrets.AWS_REGION }}' ] && echo 1 || echo 0)" >> $GITHUB_ENV

- run: pip install -r requirements/ci.txt
- name: Upload checkpoints to S3
if: ${{ secrets[AWS_REGION] != '' }}
if: ${{ env.WITH_SECRETS == '1' }}
working-directory: ${{ env.LEGACY_FOLDER }}
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }}
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/release-pkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,12 @@ jobs:
with:
pkg-folder: dist/${{ steps.folder.outputs.pkg }}
pypi-token: ${{ secrets[format('PYPI_TOKEN_{0}', matrix.name)] }}
# FIXME: this is not working suddenly, Unrecognized named-value: 'secrets'
# legacy-checkpoints:
# needs: [build-packages]
# uses: ./.github/workflows/_legacy-checkpoints.yml
# with:
# push_to_s3: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
# upload_local: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
# create_pr: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
# secrets: inherit

legacy-checkpoints:
needs: [build-packages]
uses: ./.github/workflows/_legacy-checkpoints.yml
with:
push_to_s3: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
upload_local: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
create_pr: ${{ startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release' }}
secrets: inherit