-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Torch-Tensorrt Integration with LightningModule #20808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ensorrt # Conflicts: # src/lightning/pytorch/core/module.py
Hi @Borda , friendly ping for a code review~ btw, I'm wondering if anyone could help me with the unittests during the ci, since there's compatibility problem when testing with the oldest torch 2.1.2 and torch-tensorrt. I'd love to help with solving this problem if there's any suggestion. |
I think it is fine to test for recent versions, meaning we can skip it, for example, for PT <=2.4 and add a todo note... |
|
||
""" | ||
|
||
if not _TORCH_TRT_AVAILABLE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, you can also raise an exception for some older PT versions if desired
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion!! I've added it in 15f1961
What does this PR do?
Fixes #11438
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20808.org.readthedocs.build/en/20808/