Skip to content

Torch-Tensorrt Integration with LightningModule #20808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented May 10, 2025

What does this PR do?

Fixes #11438

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20808.org.readthedocs.build/en/20808/

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels May 10, 2025
@GdoongMathew GdoongMathew changed the title Torch-Tensorrt Integration with LightningModule WIP: Torch-Tensorrt Integration with LightningModule May 11, 2025
@GdoongMathew
Copy link
Contributor Author

Hi @Borda , friendly ping for a code review~

btw, I'm wondering if anyone could help me with the unittests during the ci, since there's compatibility problem when testing with the oldest torch 2.1.2 and torch-tensorrt. I'd love to help with solving this problem if there's any suggestion.

@GdoongMathew GdoongMathew changed the title WIP: Torch-Tensorrt Integration with LightningModule Torch-Tensorrt Integration with LightningModule Jun 7, 2025
@Borda
Copy link
Member

Borda commented Jun 11, 2025

since there's compatibility problem when testing with the oldest torch 2.1.2 and torch-tensorrt

I think it is fine to test for recent versions, meaning we can skip it, for example, for PT <=2.4 and add a todo note...


"""

if not _TORCH_TRT_AVAILABLE:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, you can also raise an exception for some older PT versions if desired

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion!! I've added it in 15f1961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate TorchTensorRt in order to increase speed during inference
2 participants