[#68] Integrate Model Orphans Reporting

Trying to make it a bit more logical

Author: danielsiegl

src/LemonTree.Pipeline.Tools.ModelCheck/Checks/Checks.cs

@@ -410,10 +410,10 @@ select count(t_object.Object_Type) as ['Count'], t_object.Object_Type as ['Measu
 
             result.Level = IssueLevel.Information;
             result.Title = "Project Statistics";
+            result.Detail = "Executed Project Statistics on Model"; 
 
 
-
-            result.Detail = ToMD(resultTable.DefaultView.ToTable(), header: true);
+            result.Markdown = ToMD(resultTable.DefaultView.ToTable(), header: true);
 
 
             #endregion
@@ -431,11 +431,8 @@ internal static Issue CheckTableSize(string model)
             //resultTable.DefaultView.Sort = "table_size";
             resultTable.Columns[1].ColumnName = "table_size (bytes)";
 
-            Console.WriteLine(ToMD(resultTable, header: true));
-
             #endregion
 
-
             #region process result table and calculate Issue number
 
 
@@ -447,10 +444,10 @@ internal static Issue CheckTableSize(string model)
 
             result.Level = IssueLevel.Information;
             result.Title = "Table Statistics (all >32)";
+            result.Detail = $"Found {resultTable.Rows.Count} Tables bigger 32";
 
 
-
-            result.Detail = ToMD(resultTable.DefaultView.ToTable(), header: true);
+            result.Markdown = ToMD(resultTable.DefaultView.ToTable(), header: true);
 
 
             #endregion
@@ -482,11 +479,8 @@ AND t_object.ea_guid NOT IN (SELECT t_operation.Behaviour FROM t_operation WHERE
 
             var resultTable = ModelAccess.RunSql(statisticSql);
 
-            Console.WriteLine(ToMD(resultTable, header: true));
-
             #endregion
 
-
             #region process result table and calculate Issue number
 
 
@@ -497,12 +491,13 @@ AND t_object.ea_guid NOT IN (SELECT t_operation.Behaviour FROM t_operation WHERE
             Issue result = new Issue();
 
             result.Level = IssueLevel.Information;
-            result.Title = "Model Orphans Statistics (all >32)";
+            result.Title = "Model Orphans Statistics";
 
 
             if (resultTable.Rows.Count > 0)
             {
-                result.Detail = ToMD(resultTable.DefaultView.ToTable(), header: true);
+                result.Markdown = ToMD(resultTable.DefaultView.ToTable(), header: true);
+                result.Detail = $"Found {resultTable.Rows.Count} Orphans in Model";
             }
             else
             {

src/LemonTree.Pipeline.Tools.ModelCheck/Checks/Issue.cs

@@ -6,6 +6,8 @@ internal class Issue
         internal string Detail { get; set; }
         internal string Title { get; set; }
 
+        internal string Markdown { get; set; }
+
         internal string Symbol
         {
             get

src/LemonTree.Pipeline.Tools.ModelCheck/Checks/Issues.cs

@@ -17,8 +17,6 @@ internal string ToMd()
             var mySortedList = this.OrderBy(x => x.Level);
             foreach (Issue issue in mySortedList)
             {
-
-
                 sb.AppendLine($"|{issue.Symbol}|{issue.Level}|{issue.Title}|{issue.Detail}|");
             }
             return sb.ToString();

src/LemonTree.Pipeline.Tools.ModelCheck/Program.cs

@@ -69,55 +69,54 @@ private static int RunModelCheck(ModelCheckOptions opts)
                     issues.AddIfNotNull(Checks.Checks.CheckStrippedCompact(opts.Model));
                 }
 
-
-                // issues.WriteOutPut(Checks.Checks.CheckProjectStatitics(opts.Model));
-
-
-                Console.WriteLine(issues.ToString());
-
-                StringBuilder sb = new StringBuilder();
-                sb.AppendLine(issues.ToMd());
-                sb.AppendLine("# Project Statistics");
-                sb.AppendLine(Checks.Checks.CheckProjectStatitics(opts.Model).Detail);
-
+                Issue resultTableSize = null;
                 if (opts.TableSize == true)
                 {
                     if (ModelAccess.IsSqlLite())
                     {
-                        var result = Checks.Checks.CheckTableSize(opts.Model);
-                        sb.AppendLine(result.Detail);
-                        issues.AddIfNotNull(result);
+                         resultTableSize = Checks.Checks.CheckTableSize(opts.Model);
+                       
+                        issues.AddIfNotNull(resultTableSize);
                     }
                     else
                     {
                         Console.WriteLine("Talbesize reporting only supported for SqlLite!");
                     }
                 }
 
+                Issue resultOrphans = null;
                 if (opts.Orphans == true)
                 {
                     if (ModelAccess.IsSqlLite())
                     {
-                        var result = Checks.Checks.CheckModelOrphans(opts.Model);
-                        sb.AppendLine(result.Detail);
-                        issues.AddIfNotNull(result);
+                        resultOrphans = Checks.Checks.CheckModelOrphans(opts.Model);
+                        issues.AddIfNotNull(resultOrphans);
                     }
                     else
                     {
                         Console.WriteLine("Orphans reporting only supported for SqlLite!");
                     }
                 }
 
-
-
+                Console.WriteLine(issues.ToString());
+                StringBuilder sb = new StringBuilder();
+                sb.AppendLine(issues.ToMd());
+                sb.AppendLine("# Project Statistics");
+                sb.AppendLine(Checks.Checks.CheckProjectStatitics(opts.Model).Markdown);
+                if (resultTableSize != null)
+                {
+                    sb.AppendLine(resultTableSize.Markdown);
+                }
+                if (resultOrphans != null)
+                {
+                    sb.AppendLine(resultOrphans.Markdown);
+                }
 
                 if (opts.Out != null)
                 {
                     File.WriteAllText(opts.Out, sb.ToString());
                 }
 
-
-
                 if (opts.FailOnErrors == true)
                 {
                     if (issues.HasErrors())