implement zen mode #544
Open
implement zen mode #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #541
this pull request is based on the django_update pr #527.
it implements zen mode using template tags. i think there are likely good arguments to do it using css instead, but i don't think the code would have been much simpler, since there is currently nothing that marks something as a rating consistently, so one would still have to add a lot of html attributes. possibly using css would be more future proof, but then again, there is nothing preventing anyone not using a new html attribute for newly added ratings.
that is why i decided to hide ratings completely using tags.
i still think the main work here is to find all places that reference ratings. this should be mostly done, but of course it is plausible that i missed some places.
i decided to not remove ratings from the stats pages. they are almost completely anonymous there. but maybe one should? i prefer to wait for zen mode users to complain about it.