ISSUE #542 - detect if SSL is in use, and adjust the websocket URL to… #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… match (either `wss://` or `ws://` for non-TLS). The URLs to forward are: * /websocket/ws (the main "ticker") * /websocket/private_ws (for per-instance data feeds) - there's nothing actually "private" about it, it's "session local".
thebracket
added
documentation
|
Testing this locally, the HTTPS detection is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… match (either
wss://orws://for non-TLS).The URLs to forward are:
ISSUE #542
(Not properly tested until I'm back home. Would be a good candidate for a little documentation, too. Don't merge yet!)